Replies

Jan 16, 2016 10 years ago
Permanent
attended a Subeta meetup!
User Avatar
Crappy

Hello whenever I retrieve an item that is sold out and click back to shop I get redirected to shop zero instead of shop 38 which is the free shop. Below are links to screen shots. Sold out Shop Zero


Made by [userid=659133]
">Debt Tale Youtube Channel

Jan 16, 2016 10 years ago
far
is a gold digger
User Avatar
Fartsie

It's happening every year tho.

[font=arial]But you don't belong to the shadows[/font]

Jan 16, 2016 10 years ago
Permanent
attended a Subeta meetup!
User Avatar
Crappy

Seriously every year? I thought it would be an easy fix to change the link back button. Not a huge deal just wasn't sure if people knew it.


Made by [userid=659133]
">Debt Tale Youtube Channel

Jan 16, 2016 10 years ago
far
is a gold digger
User Avatar
Fartsie

It was there last year and the year before .. As far as I can remember.

[font=arial]But you don't belong to the shadows[/font]

Jan 16, 2016 10 years ago
Flying Ace
Speiro
User Avatar

Yeah, it's been happening for years but it's never been fixed.

If the item doesn't restock (like Melody items or CS items), then it redirects you to shop 0. If the item does restock, then it redirects you to the shop it would normally restock in, like the Toy Shop or Quick Bites.

[edit]

There's also this:


Jan 16, 2016 10 years ago Official
grace
is all-powerful
User Avatar
Beached

The reason it's never been fixed is because there's not really any way to fix it.

If the item's not in stock, there's nothing to tell the sold out page you're buying from the free shop, so it uses the item's normal shop information instead. With normal shops this works fine because the item will be sold out of the right shop, but when you're buying from the free shop it unfortunately means it doesn't have the right information to redirect you.

Honestly it'll probably be this way forever and I'll be explaining this over and over again every year :P

current steele shovel goal: 18,326 / 20,000

Jan 16, 2016 10 years ago
Flying Ace
Speiro
User Avatar

Quote by grelca
If the item&;s not in stock, there&;s nothing to tell the sold out page you&;re buying from the free shop,

Couldn't you tweak it to send the shop ID along to the error page?

I mean, this:

Quote by grelca
Honestly it&;ll probably be this way forever and I&;ll be explaining this over and over again every year 😜

sounds like a very good reason to try to fix this bug.


Jan 16, 2016 10 years ago
Kevin
is all-powerful
User Avatar
Wuf

Would making the free shop shopid=0 not do anything?

Jan 16, 2016 10 years ago
Flying Ace
Speiro
User Avatar

- Only if you missed out on something that doesn't stock in a normal NPC shop. If you missed out on one of those new cooking oils for example, it would take you to the food shop.


Jan 16, 2016 10 years ago
Kevin
is all-powerful
User Avatar
Wuf

Yeah which is a much better alternative imo because at least those are real shops that have restocked since the unix epoch date.

Jan 16, 2016 10 years ago
Permanent
attended a Subeta meetup!
User Avatar
Crappy

I get it but that must be annoying on your end to explain every year because I am sure it happens. 8 years and I am surprised by little things that others have noticed in the past.


Made by [userid=659133]
">Debt Tale Youtube Channel

Jan 17, 2016 10 years ago
Flying Ace
Speiro
User Avatar

Quote by Speiro
Couldn&;t you tweak it to send the shop ID along to the error page?

Wait. You already have the shop id on the error page. It's in the url:

https://subeta.net/shop.php?shopid=38

So shouldn't this be a really easy fix? You already have the data you need without having to query the database or anything.


Jan 17, 2016 10 years ago Official
Keith
attended a Subeta meetup!
User Avatar
Eradication

Just pushed a fix for this :)

💖 ✨ 🤗

Jan 17, 2016 10 years ago
grace
is all-powerful
User Avatar
Beached

Quote by Speiro
Couldn&;t you tweak it to send the shop ID along to the error page?

Wait. You already have the shop id on the error page. It's in the url:

https://subeta.net/shop.php?shopid=38

So shouldn't this be a really easy fix? You already have the data you need without having to query the database or anything.

can i just claim longtime blonde moment on this one? 😂 😂

current steele shovel goal: 18,326 / 20,000

Jan 17, 2016 10 years ago
Flying Ace
Speiro
User Avatar

Quote by Keith
Just pushed a fix for this :)

It works perfectly now. Thanks! :D

While you're here, do you know if anything can be done about the broken "image" on this error message?


Jan 22, 2016 10 years ago
Spotlight Champion
Destiny
User Avatar
Dexter

or May be able to fix the image issue! I vote for either or

Dexter by

Jan 23, 2016 10 years ago
The Adventures of
Ariel
and Pete
User Avatar

I had actually asked Grace about that when we were testing it and I can't remember the details other than it was complex haha. I'll check again!

Jan 23, 2016 10 years ago
Flying Ace
Speiro
User Avatar

- It should probably just be the Experiment , because that's what all the other error messages use.


Jan 23, 2016 10 years ago
Spotlight Champion
Destiny
User Avatar
Dexter

That's no fun though :(

Should I go ahead and close this since the image is another matter or did you want me to leave open until we find out?

Dexter by

Please log in to reply to this topic.