Replies

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

Please use this topic for general feedback and bug reports. If you have suggestions for new features we can add in the future, please post them in the Suggestions and Ideas forums. Thank you!

First off, apologies for pinging siteupdate since this is the first of two pings you guys are gonna get today (there will be another for our sprint update at the end of the day). However I wanted to do this in the morning so that I am here in case anything goes wrong.

Features and fixes

These problems were fixed in this version of the vault:

Searching only grabs page 1 - Mentioned in topics Vault search, Cannot access page 2 of vault search, and Filter Vault by rarity only works on 1st page for instance. Difficulty combining search filters - Mentioned in above topics. Combining search filters (like category + stack size + rarity) was tricky or sometimes impossible. Glitchy caching - Mentioned here Vault - Cache? Category Management - Mentioned in topics like [topic not found], ability to edit vault category names, etc

Here's what the new vault features:

  • Easier search filters - The old search filters (a combination of clicking and typing) have been rewritten as a form where you can select exactly what you want to filter by, and it'll work.
  • Search past page 1 of results - Yup, you can now browse all the pages of your search results.
  • More accurate cache invalidation - Things should no longer linger in the cache after you change them.

Finally, a few other tiny things:

  • Quick vault quantity doesn't jump like 10, 25, 50 anymore, it just has all the numbers from 1 to 50. Hopefully that's better?
  • Categories are listed alphabetically. (More on this below.)
  • Sorting options can each be ascending or descending now. (Previously, only userprice had both ascending/descending options - the rest were ascending only.)

VAULT CATEGORIES Also part of the rewrite I added a categories page. Find it by clicking the link under the Category dropdown in the search filters. On this page, you can create, delete, and rename vault categories. The page has instructions on how to do these things. Please note: Custom ordering is not currently possible, but vault categories will show up alphabetically in the new vault, so you could put a number in front of each name (for instance) to force an ordering for now. (We ARE planning to add custom ordering in the future.)

Reporting a bug?

Please use this topic for bug reports.

BEFORE REPORTING A BUG

  • Clear your custom CSS to make sure it's not a conflict with the custom code
  • Make sure your browser is at 100% zoom (for layout problems?)
  • Check your browser extensions and settings (something might be blocking the Javascript)
  • Make sure the bug happens to you more than once; if you can't reproduce it, it could've been a one-time fluke or due to random lag/unrelated factors.

WHEN REPORTING A BUG Please include this information:

  • Browser and browser version
  • Operating system + version
  • What device are you on (laptop, mobile, tablet, etc) If you can give instructions on how I can trigger the bug for myself, that would be super helpful. Otherwise I'll ask you questions to try and get more info.

Beta testing seemed to go smoothly, but if something goes terribly wrong then I will temporarily revert the update. If this happens I'll edit this post so you know why you're seeing the old vault again. Thanks.

siteupdate

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

OOPS GIMME ONE MINUTE.

[edit] SORRY ABOUT THAT Just pushed a fix to take that out, wow omg sorry. It'll be like 10 minutes I'm sorry guys T_T

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by buddleia
The category dropdown menu defaults to saying &quot;all items&quot; but it&;s actually displaying my Unsorted category, when:</p>
<ul>
<li>coming from Category Rename page back into main vault</li>
<li>having just moved one item to inventory via the &quot;X&quot; or &quot;All&quot; buttons

This is because, while beta testing, we found that having the dropdown default to Unsorted caused more confusion when people used the search form because they expected the vault to search all items, not just the Unsorted category, just like the previous version of the vault. The compromise was to make the main page of the vault show unsorted items (as before, and this is definitely not changing because showing all items on the main page would place unnecessary strain on the database) but have the search form default to all items. I'm not currently planning to change this again.

For your other two points, I think those might not be as problematic after you've taken some time to get used to them. In general for UI feedback I find it's better to wait a couple weeks because initially it's hard to tell what's going to stay a problem and what's going to be fine once the new UI becomes more familiar.

Thank you for letting me know, I'll take a look at both.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

the two things you reported should be fixed now :) Let me know if you see anything else.

Quote by Jessica
I liked the jumping of 10, 25, 50. I find it makes the dropdown so long and ugly with it listing every single number
It was changed because people complained about the jumping when it was like that previously.

Quote
Why does the very last row in every page have 4 items instead of the usual 6 like all other rows? Makes it look..uneven
The number of items shown per row will depend on your window size/screen resolution. There is not a fixed number of items per row. Instead, it is fixed at 250 items per page and each item just takes up the space it takes up, which are an intentionally compact size and about the same size as they used to be (as users generally seem to dislike when whitespace is added to site features)

Quote
The category updated alert is cool, but personally I preferred the old vault&;s way of putting it right below the category dropdowns. They don&;t disappear at least.
The problem with them not disappearing is that, if you then change the category of the same item a second time, you get zero feedback on whether or not it worked. If we do place it back under the category dropdowns (like I mentioned above, I want to give it more time before making a call on that) it will still fade out after a couple seconds. The main reason I wanted to move it out from under the category dropdowns, is that either it changes the height of each item box which pushes the grid down, or we have to add a lot of whitespace to the bottom of each item to make room for it.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

That might be possible, but it's something we'll have to discuss. I definitely agree that it would be a useful feature :) However there's a lot of considerations with something like that, like we'd have to integrate it with both the existing search code and caching code (which is really complicated) so I can't give a definite yes or no to it right now.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

Just pushed a fix for the caching issue. It was an issue on quickstock/inventory pages, not the vault page, that was not clearing the vault cache correctly.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

Yup doing a rollback wait a few minutes

so uh, jk about the last fix, I reverted it cuz it broke the whole site WHOOPS. I'm gonna work on a better fix and will let you know.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

I've attempted another fix for that cache problem, lemme know if it's working now? D:

Though another workaround is to change an item's category - that should also reset the cache if you need to force a cache reset, and is easier than removing it and adding it back in.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

The 504 at that time was probably a temporary thing because the site was updating - I just pushed a code update and it always slows down a bit when it updates itself. Hopefully that's all it was! Definitely let me know how it goes for you later.

Hey I think I finally fixed it!! Go check!!! :D

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 7, 2017 8 years ago Official
Bug
User Avatar
Segfault

You can always make bookmarks of your categories (either as Subeta bookmarks or just normal browser bookmarks). Just select the category from the dropdown and make a search. Then, bookmark the page you land on, or copy its URL and you can link to it wherever you want.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 8, 2017 8 years ago Official
Bug
User Avatar
Segfault

Not entirely sure, but I'm guessing you're talking about categories being moved to a dropdown because you have to scroll in the dropdown selection?

I'm afraid that's not something we are going to change back at this time. The dropdown is meant to be more consistent with other areas of the site that have item filters (think shop/gallery categories, wardrobe drawers, etc) and is a lot more organized than listing them as horizontal links.

If you're referring to something else you'll need to be more specific, because nothing else was changed that would increase any amount of scrolling.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 8, 2017 8 years ago Official
Bug
User Avatar
Segfault

It looks like you're having a layout glitch. Try seeing if any of the following help fix your issue:

  1. Clear your custom CSS
  2. Check that your browser settings don't disable scripts on subeta
  3. Check your browser extensions and try disabling ones that might interfere with loading external scripts (for instance, adblock)
  4. If you have any userscripts installed, disable them temporarily to see if any of them might be causing the issue

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 10, 2017 8 years ago Official
Bug
User Avatar
Segfault

Yes is correct. Normally when there are items, page numbers show up on both the top (above the items) and bottom (below the items) for your convenience. However, when there are no items, you simply see both sets of page numbers (which just show page 1 since there is only one empty page) and nothing in between.

I could add some text when it is empty, to say "No results found" or something? (Any suggestions for this text?) But I'm also not sure if it's worth it, it wouldn't be too hard but I'm also afraid of it confusing people if that message wasn't there before and suddenly began to show up haha.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 14, 2017 8 years ago Official
Bug
User Avatar
Segfault

thanks for letting me know! Fix incoming :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Please log in to reply to this topic.