Cache in Item Vaults
Filter
Show Official Posts OnlyReplies
- I do a vault search, and then try to do another search for literally anything else. Any subsequent searches I do will return the same results from the first search for as long as it's cached, which is somewhere around 5-10 minutes.
Thank you. I'm working on a fix for that right now!
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
That was what I was hoping would be dealt with when the cache was reduced, but it's nice to see it can be completely fixed even with the cache still there
I've just tried moving something to a different category, and it's not showing up correctly right away. :c
[edit]Also item amount numbers aren't updating right away after adding more copies of an item to my vault. Same for when an item is removed.
Yes, I'll try and explain it in a bit (once it's all dealt with). I've just pushed a fix for the search results caching that you'll see in a bit. (15 minutes or so)
Thanks, I'm working on that next. <3
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
<p>I&;ll be back in a bit with a better explanation about the caching and what was going on with it (based on what I know - I haven&;t looked at it yet personally) I understand this was a frustrating issue.
Yes. I go to the front page of my vault and put items in categories. Then I refresh the page. The items are still there and it says they are in no category,
Then I go to the category and the items are there, but they are ALSO on the front page of the vault.
Also items still appear in the vault for several minutes after I move them to my inventory and quickstock them in my shop. It's driving me insane because when I quest I throw everything in the vault, sort it into categories when I'm done and then upload. I have a gold account so if I do all my quests my inventory overflows especially with a billion pumpkins spawning, I use vault categories to sort items so that I can then move them back into my inventory in groups to go to each of my shops, my wardrobe and the fragmentiser. The only thing that stays in my vault for very long is pet food. Most things I keep go directly into my wardrobe with my 50 drawers, or my pets' treasures. I keep things I won't use and can't sell for 2-3 days at a time in a category called "frag bag" but at the end of 2-3 days I frag them all.
Slotting | CW Shop | Owned List | Releases
[KISS=Valiska] * [DANCE=Valiska] [Flower=Valiska] * [tot=Valiska] * [egg=Valiska] * [tp=Valiska]
I just pushed another fix. Things that should be working:
- When you change the search term, it should show the correct new results
- When you change the category of an item, it should show correctly when you view the vault home page and the category and stuff
- When you add/remove items it should show the correct amount when you look again
Ping me with anything other issues you'd like addressed.
[edit]
Then I go to the category and the items are there, but they are ALSO on the front page of the vault.
Also items still appear in the vault for several minutes after I move them to my inventory and quickstock them in my shop.
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
Search seems to be working okay for me.
Changing categories, the items are disappearing from the category they were in right away, but still taking a minute or so to show up in the new category. Also item numbers are also still not working exactly right, not adjusting immediately that is.
Thank you, those should now be fixed as well (and by now I mean within 15 minutes - it's gonna take me forever to get used to this new wait time haha)
Let me know around 11:55 if you're still having other problems. (This goes for everyone else too!)
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
It all seems to be working now! Thanks for taking care of this <3
Awesome! That's so good to hear.
Okay so now that that's taken care of, let me explain a little bit about how caching works (on Subeta and in general), to clear up why we have it and what was happening here. Under a spoiler for the curious.
SPOILER (click to toggle)
As you know, most of our data is stored inside a very large database. When you visit things like the vault, it does a query on the database to retrieve the items list. It is this query that is the slowest part of the vault, because it requires searching a huge database and then loading a huge amount of data into computer memory. So let's say you visit the vault home page twice. This is what happens without any cache involved:
- Visit vault home page - It loads items from the database (slow)
- Visit vault home page again - It loads items from the database (slow)
When we cache something, it means we keep it around in the computer memory for a while. So instead of the above, this is what it looks like:
- Visit vault home page - It loads items from the database (slow) and caches them in memory
- Visit vault home page again - It loads items from memory (fast)
Basically, it speeds things up by keeping the items in memory instead of having to load them from the database again and again. If you're looking at a page in your vault, and then you open the same page in another tab for instance, it can just give you the data it already has, instead of computing the same data all over again.
However, if the database changed in the meantime, the cached data will not reflect that change. The solution is to tell the cache to delete that data when you make changes to the database. So what we had to do here is that whenever you made changes to the vault (like adding/removing items) we had to tell the cache to update itself in a "smart" way, so it's not showing you outdated results. That was the main problem here - we were caching things aggressively, but we hadn't set it up to update properly when the database changed. That in itself was kind of complicated, because there were a lot of operations that needed to be considered in the item vault: add/removing items, changing categories, all the different searches you can do... etc.
Though a cache can store data with much faster read/write times, there are still tradeoffs to using it, which is why we still need a database (instead of just using the cache to store everything). For one thing, it relies on computer memory which isn't persistent nor is it a lot of space. The database has a lot more space in it, is persistent, and offers a lot more utilities like complex searching and sorting, whereas a cache is much more limited in both storage capacity and what it can do.
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
<ul>
<li>When you change the search term, it should show the correct new results</li>
<li>When you change the category of an item, it should show correctly when you view the vault home page and the category and stuff</li>
<li>When you add/remove items it should show the correct amount when you look again</li>
</ul>
<p>Ping me with anything other issues you&;d like addressed.
Looks good! Thanks.
Slotting | CW Shop | Owned List | Releases
[KISS=Valiska] * [DANCE=Valiska] [Flower=Valiska] * [tot=Valiska] * [egg=Valiska] * [tp=Valiska]
Thanks for the fixes and the great explanation !
What did Subeta do to deserve you? <3
Thank you for getting it all fixed up so quickly! ^_^ The explanation was very helpful too.
🔭🐢
I dont have a problem with the cache. I have problems with the vault. For example organizing things into categories and searching is a pain in the butt. I'm probably one of the people causing the strain as well because my vault was 104 pages last week but sorting through it is always such a hassle.
I will say that it does seem like it's loading faster now and that does make difference.
A new and improved vault is in the works.
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
I'll just ask the inevitable question: will the vault (and eventually wardrobe) get an item/space limit like shops and galleries now have? As unpopular of a suggestion as it may be, I definitely feel there needs to be more limits in place, especially those two areas. Plus just gives GAs more perks for doubled space. Would also discourage hoarding and force users to either use or sell items sitting in their vault/wardrobe.
Wanna know more about battling? ❤️ The Official Battle Guide v3.3 ❤️ Need to find books? 🌈 The Book Grind Guide v1.0 🌈
This is getting a bit off-topic now, but on the subject of vault or wardrobe limits.
I'd be fine with a limit on vaults (maybe a larger limit than we currently have with shops/galleries, but some sort of limit).
IDK about for the wardrobe though. I know it can be the source of a lot of lag, but there are seemingly endless amounts of clothing items between regular site items and CWs. And since you can't exactly "use" every wearable you have at once, I think it would be a bit unfair to force users to choose only their most favorite clothing items to keep.
Unless the wardrobe limit was really high, I just don't see that going over well at all.
The site has been running fine since we increased caching on the vault, and the increased caching is no longer an inconvenience for users since I fixed the caching logic two days ago. The holiday started off kinda terrible sure, but we've addressed the issues that surfaced. Morostide is still in full swing and we're running smoothly. Vaults are no longer causing major problems.
If you want to suggest that we add an item limit, feel free to make a topic in the Suggestions forums to host further discussion.
Let's try to keep it on-topic here. :)
🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights
I&;ll just ask the inevitable question: will the vault (and eventually wardrobe) get an item/space limit like shops and galleries now have? As unpopular of a suggestion as it may be, I definitely feel there needs to be more limits in place, especially those two areas. Plus just gives GAs more perks for doubled space. Would also discourage hoarding and force users to either use or sell items sitting in their vault/wardrobe.
I agree that there needs to be more limits in place - and we design features now understanding and thinking about that. I've gone back and forth a lot of times on implementing a hard limit on the number of wardrobe items you can have, and we've discussed it a lot both on staff (and here) about making items unremovable so that people are less likely to toss in huge 10k+ collections of items.
As with vaults, we've always come back on this being really harmful to gameplay - especially with vaults. They're where all of the items on your account end up, and I think it just takes us reworking them on the backend and doing more things like this caching update. There is a lot more that can be done with caching the vaults that I'm going to investigate going forward that will hopefully make it less likely you ever hit a database query after you've loaded them.
We do something similar for the wardrobe, and can always do more to tighten both of those things up.
tldr: Features are created now with limits in mind, we are always looking for ways to speed up the site and ensure a good user experience with things like caching, and have no intention of adding limits to either the wardrobe or the vaults. If one of those were more likely it'd be the wardrobe, but I just don't think it's possible for us to do that at this point in Subeta's life.
💖 ✨ 🤗