Replies

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

New Hair Salon!!!


The much-anticipated HAIR SALON REVAMP is now live and ready-to-go! Check out the new hair salon here: https://new.subeta.net/wardrobe/hair

This update features both brand new code (inside and out!) and a redesigned salon page which we hope will make hairstyles easier to understand and play around with! ✨

Background and Extra Info From an older staff post (when work on this was still ongoing):
Quote
We&;ve spent months playing whack-a-mole with the Hair Salon in 2020; fix one issue, and another pops up. Our plan now is to rewrite major parts of the code behind this, taking what we&;ve learned from these issues to replace the current code with code that&;s robust, well-designed - and free of the current Hair Salon&;s endless bugs!

Over the course of this work, we identified what worked and what didn't work in the previous system, and kept those in mind when making decisions about the new code. We prioritized both robustness and efficiency, and also took this opportunity to try and improve the user interface.

For example, one huge issue with the previous hair salon was inconsistency of data. Over the years, hairstyle data would be stored in different formats, to the point where it was difficult to fix a problem with one outfit without breaking another. These inconsistencies were confusing and made coding error-prone, both of which contributed to the endless "whack-a-mole". With the code redesign, we started by asking what an ideal data format would look like for hair styles - using valuable lessons from everything we tried in the past - and added contracts throughout our code to enforce consistency with the new format moving forward.

On the user interface side, the new page features several improvements over the old one. For example, we re-organized and renamed the color options to make them easier to use and understand. We hope the palette system makes it easier to experiment with different color schemes too! And the scissors icon next to each hairstyle can be used to edit any saved hair, loading its colors into your palette if they aren't already there.


Bug Report Guidelines

As usual, we'll use this thread for both general feedback and also to take initial bug reports. Please read the following notes and guidelines first:

Important Bug Report Notes and Guidelines!!!

  1. We expect that some outfits saved before this update may still not work correctly. If you have saved outfits with broken hairstyles, please list a few examples using the outfit sCode in a single post. I'm working on scripts to convert these to the new hairstyle system over the weekend!

This problem occurs because the way hairstyle data was stored changed over the years and grew inconsistent, to the point where the wardrobe could not load some things correctly without breaking other things. One of the major goals of this revamp was to make this data more consistent behind the scenes, to avoid this moving forward!

  1. If hairstyles are not showing up in the list, first check both Earned AND Unearned just in case. If it is still missing, please let us know which hairstyle it is as well as the exact values you have in the search filter.

  2. If you are wearing a hairstyle from before this update, you can convert it by: click "scissors" icon next to the hairstyle, click "add to avatar" on the customization page, and then click "wear" to save it to your HA if everything looks good.


Thank you for your support, and extra thanks to those who helped test and give feedback during the beta! Please enjoy the new Hair Salon! <3

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

Thank you! Working on fixing the name search :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

Name search should be fixed now :)

Thanks for catching that! I was trying to manually remove duplicates earlier (there were quite a few for some reason) and I must've missed that one.

[edit] The duplicate Blaze hairstyles have been fixed. I just confirmed there's no other duplicates too.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

That should've been capitalized, but as far as I can tell, that hairstyle has always been called Base. That's how it's named in the database, and all of the image files also say "base" (and none of those were renamed for this update)

The other bug is one for so I'll pass it along, good catch! And thank you too! Let me share the credit with - We split the work pretty evenly; he built the brand new user interface while I worked on the code behind-the-scenes on the server. :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

Hm, are you still having that problem today with images not loading? They might take a second or two to show up, especially when you click in and it has to build the preview image from scratch. The occasional 504s make me think those endpoints - and the images - were timing out for you, so I'll look into if lag spiked last night and what might have caused that. I'm not noticing any lag or broken images at the moment.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

Ohh I see what you mean, thank you for the list. Looking into them.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

No worries, I appreciate that you took the time to list everything <3 Those hairstyles should be fixed now, aside from Enigma Short and Wen (Beardless), which seem to be separate errors from the rest... still working on those.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

May 21, 2021 4 years ago Official
Bug
User Avatar
Segfault

Enigma Short should be fixed now. I also fixed Wen (Beardless) by renaming it to Wenbeardless for now. I'm gonna leave it like that for now, but I've added "make beardless wen work with a readable display name" to my todo list, lol

Omg, seriously, ALL of them? That's really impressive. I have maybe half of them unlocked myself.

Thank you so much! Those examples are really helpful. It looks like the hairstyle data is intact, and it just has the wrong ID, so they should be fixable. I'm hoping to make a script to find and fix all of these since probably a lot of other people are also affected by this - over the weekend, since I'm about to head off for the evening. TY again <3

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Jun 10, 2021 4 years ago Official
Bug
User Avatar
Segfault

Hey, sorry it took me so long to get back to you. I've fixed those 3 saved avatars for you. If the images are still broken, you can try clearing your browser cache, or hard-refresh on the image URL. :)

Thanks for the report - I'll see what I can find out about the Case hairstyle. To clarify, you cannot add a Case hairstyle to a totally new HA either right?

Thanks for the bug report - that's one for so I've passed it on. As for your other question: There's currently no way to automatically apply the palette to new hairstyles, but we hear you that you'd like such a feature! We'll definitely discuss it as a future improvement.

Currently, the hair salon doesn't have a way to select and edit an existing color. You can only add new colors, or click to remove them. But I totally see what you mean. Thanks for the suggestion!

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Please log in to reply to this topic.