Replies

Jan 8, 2018 8 years ago Official
Bug
User Avatar
Segfault

1/21 Notice - The remaining sCode issues will be smoothed out asap! It's not gonna be forgotten. I've just been unusually busy with offline stuff this weekend.

New sCode Processor

Hello everyone! This post is to let you know that we've begun to gradually roll out the new sCode processor. Please read the FAQ below as it touches upon what you will notice, and how to report any problems. Please make sure you read this FAQ thoroughly before asking a question or making a report. Please make reports in this topic.

Known problems As problems are reported, they will be listed here, so you know what's already on our radar.

  • bug/butterfly emoji (and possible battle damage icons)
  • line breaks in SB
  • CSS inside style tags breaks if it has square brackets
  • Need to correct aligned images to float
  • Friend feed line breaks
  • "Open links in new tab" preference is not respected (probably cant make it do that tho..)
  • Harvest link does not work (maybe intentional, have to look into it)

[spoiler=things that have been fixed]

  • Broken item hovers and images on the armory, scroll library, and alchove
  • Quests missing item name when asking for items
  • Editing a post makes the edit show up without line breaks
  • User hovers broke the entire page on user CW shops
  • Url tag breaks with links that have a = character
  • Url tags require the http part (it should now work without it!)
  • Url tags that are just the URL itself stopped working
  • Code tag breaks if it contains invalid sCode
  • Tickets are missing linebreaks
  • Bday icon shows up teeny tiny in the user hover
  • Giant link on sMail page
  • avatar sCode was left out, whoops
  • Item Scramble has some broken images
Things that will not be fixed
  • Event sCodes and pings do not have the user hover
  • [/spoiler]

    Troubleshooting

    If you're noticing broken code, please read the following spoiler for things to try:

    Troubleshooting broken code The new filter is a lot stricter about enforcing the rules of both sCode and HTML. It also has a few quirks of its own. Here are some common issues to look for if your code has stopped working. For more help go to this topic, which has the same list there as well: Profile Issues following sCode Updates

    [spoiler=Spoiler titles] When using the spoiler= sCode, you can no longer include sCode within the title; it must be plaintext. If you need a fancier title, you can use this workaround for now: [spoilertitle]

    Fancy title
    [/spoilertitle][spoilercontent]Hello world![/spoilercontent] Which will look like this: [spoilertitle]
    Fancy title
    [/spoilertitle][spoilercontent]Hello world![/spoilercontent]
    Style tag and quotes When including CSS in a profile, make sure your style tag is opened by one of the following: (Preferred) <style type="text/css"> <style> Examples of things that won't work: <style type=text/css>

    <style type='text/css'>
    Order of closed tags Make sure that nested tags are closed in the correct order. For example: Hellowill result in an error. The correct order would be: Hello
    Extra line breaks due to br tag In some places, if you use both a br tag AND a line break (via the enter key), it will interpret each of those as a line break and will give you double line breaks as a result. For example: hello
    world
    Will give you two line breaks. But this will give you just one line break in between the lines: hello world This will also only give you one line break: hello
    world
    Square brackets inside CSS If you have something like this inside style tags, it will break: div[style^='width:50%'] { display:none; } This is because of the square brackets within the code. This is unintentional, and will be fixed, but is mentioned here because it could be causing your code to break.
    Make sure you check for other HTML syntax errors as well, such as: missing quotation marks, missing closing tags, incorrectly closed tags, etc. Still having issues? Please paste your code somewhere (we recommend Pastebin.org) and ask for help in this forum or Profile Issues following sCode Updates. Make sure to include a paste of your code to make it easier for others to identify the issue. [/spoiler]

    General FAQ

    Q: What is the sCode processor? A: The sCode processor is what turns your sCode into the actual HTML that gets displayed on the site. Q: What is this update, and why was it necessary? A: This update is a rewrite of the sCode processor. The old version was holding us back from upgrading our PHP version to PHP7. The primary goal of the rewrite was to remove the old dependencies so that we could move forward with the PHP upgrade. Along the way, we took the chance to modernize the code and make some minor improvements here and there. However, it is primarily a rewrite of an existing feature, which means the changes should not be drastic in this version. In general, sCode should continue to behave the way you expect. Q: How is it being rolled out? A: This is going to be rolled out gradually with our new "feature flags" system, which means not all users will have it on to begin with. In the beginning, most users will still be seeing the old sCode processor. We will turn the new sCode on for Gold Accounts first. Then we'll turn it on for 10% of normal users (for instance), then 20%, and so on, gradually introducing it to the entire userbase. Then we'll upgrade to PHP7 yay!!! Q: What are the changes I will notice if it's on for me? A: A couple sCode tags have some minor changes to them, which I will list here - * The spoiler tag opens and closes with a sliding animation. * The pet sCode shows the name below the headshot, and links to the pet's profile. * The code sCode renders the contents in monospace font. * The outfit (shared avatar) sCode no longer automatically centers itself. You can still center it with a center tag, however. * The quote sCode has been tweaked to be more readable. These bugs were also fixed in the new sCode only: * Spoiler tags do not work on user profiles. * When a spoiler tag is opened, all nested spoilers would also open. Q: Forums seem to be using the new sCode? A: Forums are basically all using the new sCode right now because they work a little differently from the rest of the site. However sCode is used throughout literally every section of the site, so the other sections are still being rolled out gradually. Q: What kind of bugs should I report? A: You should report it if any sCode is acting incorrectly for you. (It doesn't matter if you're still on the old sCode, or are unsure.) Here are some common glitches we've seen that you should most definitely report if it happens to you: * Line breaks go missing completely. * Line breaks turn into double-line-breaks leading to too much spacing. * Codes completely breaking or not working - will be very obvious if this happens. Q: What should I do before and when reporting a bug? A: Before reporting a problem, remove your custom CSS (if any) to make sure it is not being caused by custom CSS. If you have anything else that could be affecting webpages (such as user scripts or some browser extensions), try turning them off as well to make sure they are not causing the problem. When reporting the bug, you should include: * The exact page you got the error on - please provide the page URL. If you are getting it on multiple pages, please provide some URLs as examples. * If possible, provide example text for the error (that is, what you were typing into the text box that caused the error) * The browser and browser version you are using, as well as device if on a mobile phone or tablet. * Be as descriptive as possible about what you noticed triggered the bug. Again, go ahead and use this topic for reports, questions, concerns, etc and feel free to ping me in your posts as well. # siteupdate

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    ...no, it's not meant to imply anything. The main goal of the rewrite was to modernize the code so we could upgrade to PHP7. The purpose of this announcement was to make people aware that changes are happening, so no one panics if they see really wonky sCode somewhere on the site, they know why it's happening all of a sudden and where to report it :)

    It's such a big rewrite that I don't expect a 100% smooth transition, I expect at least a few glitches to pop up. But by being transparent about it, and rolling things out very gradually, we hope to make the transition to the new code as smooth as possible.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Fix incoming for the broken spoilers on forums :)

    [edit] and fixed!

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Some personal replies..

    Quote by Mackenzi
    Will there be more changes once we are upgraded to PHP7? Idk what that really means, besides simply a more up to date system.
    Upgrading to PHP7 will allow us to make significant improvements to basically everything :) Not only will we get the speed, efficiency, new features etc of PHP7 itself, we'll be able to upgrade a lot of the other tools we use to newer versions that require PHP7, and we'll be able to use newer tools as well. So this is a much-needed upgrade we're working towards, and will have positive effects across the entire site :)

    Quote by sentinel
    I don&;t know how much changing processors will affect this, if at all, since the symbol isn&;t used in a scode... but will the change in processor be able to eventually help fix the fact that the &gt; symbol doesn&;t show up on profiles? It drives me up a wall 😭!!
    Unfortunately I don't think it will, since - as you mentioned - that problem isn't caused by the sCode processor. It's caused by the code that filters your HTML to make sure no one uses malicious code, on pages that allow custom code. We can certainly look into it, but it's a separate issue, and it may be a tricky one since there's security concerns involved.

    Quote by nut
    lskejfleijowfijw
    efpwiejfwj
    weifjoweifjowej
    wjeifowiefjw
    iwjefowiefjow
    Thank you for your feedback.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Thank you so much for the report! Looking into it right now.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Okay, the armory and scrollery should be showing up correctly for both those with new sCode on and those still on the old sCode :)

    Please continue to ping me for broken stuff like that :) thank you so much!

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    @ Laurey Ooh, interesting, thank you. On it :)

    [edit] Fix pushed and will be live in the next 10-15 minutes or so.

    Once the fix is live, you may want to refresh the cache on your forum post by editing it.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Nice catch, fixing now.

    [edit] Fix pushed, update in progress :)

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    @ Woven Hmm... I'll see what I can do about that preference.

    [edit] It's difficult to make the filter respect the preference, and it's impossible (and always was, afaik) to make it respect the preference on the forums. As a compromise, I could do something like...

    [url target=blank]www.subeta.net[/url] ...opens in a new tab, but www.subeta.net ...opens in the same tab.

    So that would at least give you some control over it, if we can't outright pass it that preference somehow. What do you think?

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Yes, you understand me :)

    What do you mean by "problem", can you describe what you're encountering? The more descriptive, the better :) Can you provide a screenshot of what you're seeing, perhaps? The spoiler in that post works correctly for me. What do you mean by "disappears completely", like the spoiler just completely disappears? And only if you refresh the page? What's it look like right now?

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    I think your spoiler code is a bit broken, you have an equals sign without anything after it.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 8, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    I figured out it is because of your unclosed "size" tag. I'll see about making that more forgiving. For now you can fix it by only putting the "size" tag around text.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 9, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    For now they won't. I'm going to add it to the first post though, I will try to modify the code to automatically correct it.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 9, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Nesting things in the spoiler title like that won't work anymore, I'm afraid. The new sCode is much stricter than the old one, so putting something as a tag "attribute" like that doesn't allow for nested code.

    There is a workaround you can use. The CSS on this doesn't currently match, but that's something I can fix. I'll see about cleaning this up and putting it in the sCode reference as an official alternative, if you want to do fancy stuff with it.

    [spoilertitle]

    hello
    [/spoilertitle][spoilercontent] lorem ipsum dolor sit amet [/spoilercontent]

    [spoilertitle]

    hello
    [/spoilertitle][spoilercontent] lorem ipsum dolor sit amet [/spoilercontent]

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 9, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Thanks for the reports! All of the issues you reported have now been added to the first post, so they're on the radar :)

    I'm thinking of heading to bed soon ish, will pick back up with these tomorrow.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 9, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Wow, that's really weird.

    Could you view the source code of the page and try to figure out where that link is happening? (Like there must be a stray a href near the top of the page, but.. where exactly? I find it intriguing that it's not just the sMails but the entire page turns into the link...)

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 9, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    I figured it out and have pushed a fix! This one was baffling to pin down.

    It happened under very specific circumstances: when you get a reply to an sMail you sent, you'll get a sidebar event saying something like "You have a reply from X in your inbox!" which links to your mail page. That's what caused the page to break. The event link had an unclosed link tag. Usually your browser is smart and can automatically "fix" broken HTML like this but on the mail.php page (which has a lot of other malformed HTML) it wasn't able to do so.

    The giant page-link can be fixed therefore by simply deleting the event.

    The fix I pushed should cause all events from here on out to use a correctly closed link :) However any notifications you had from before will still have the malformed link since they were created before the fix was out.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 10, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Thank you! Added to my to-do list (first post)

    It looks like I just forgot the avatar scode completely ;-; I knew I'd forget something. I'll have that corrected asap. My bad.

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 10, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    The font-weight is the same as ever, so I'm not sure what you could be seeing.

    Could you share a screenshot to show what you mean by extra spacing on comments? And is this on all the comments pages, or just P2P comments, your comments, or one of the other specific pages?

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Jan 11, 2018 8 years ago Official
    Bug
    User Avatar
    Segfault

    Hey thanks for all your help finding bugs here and there.

    • Admin post page has been fixed (will update very soon!)
    • Avatar sCode is back!
    • The birthday icon size should be fixed too, I gotta find someone that has it though, to confirm.

    Things that have been removed and won't be fixed at the time:

    • User hovers in pings and event codes

    As for the Harvest sCode, I'm still double-checking on whether to add that back in since it's an old function. I'll have an update on it soon.

    Let me know if I missed anything, I went back through the last 3 pages of forum posts but there was a lot to skim.

    Fix for item scramble has been pushed :) Thank you!

    I'm planning to update the sCode reference after this is more fully merged. You can remind me if I forget to do so, I think I must've forgot last time cuz I swear I added the egg and tp scodes, like I seriously thought I did xD

    🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

    Please log in to reply to this topic.