Replies

Nov 27, 2017 8 years ago Official
Bug
User Avatar
Segfault

closed - 12/7

It's been pushed :) New topic for it: Item Vault Updates Don't go on my dev site anymore haha. I'll have a separate one for beta testing from now on :D

The new vault hasn't been pushed yet. It's on my development site, so that's where the link will take you. However I also use this for other stuff. I'll try to leave the vault up for testing whenever I can. However, if I have to switch out, I will close access to my development site while I'm doing whatever I need to do. If you get an error message telling you it's a dev site and to head back to Subeta, that means I'm doing something on there, so just wait a while and check back later.

Other than that, do not do anything on the dev site other than test the vault. Don't visit other pages or play Subeta there. It's pretty much identical to this site, except it's not guaranteed to be stable, and if you get into trouble there I can't really help you out since you were warned.

Pages you can use on the dev site: Vault, Your shops, Quick stock, and Inventory These are the pages included in the testing. These last three are for testing moving items into the vault.

My dev site has some other quirks (for instance, floating items will open in a new page instead of a pop-up) - If it's not related to the vault, please don't report it lol. My dev is a strange and scary place XD

This is a long post but please read it all if you wish to help test. Thanks! <3

New vault features and fixes

These problems were fixed in this version of the vault:

Searching only grabs page 1 - Mentioned in topics Vault search, Cannot access page 2 of vault search, and Filter Vault by rarity only works on 1st page for instance. Difficulty combining search filters - Sometimes it's possible but unintuitive/difficult, such as when filtering by rarity and stack size at the same time. Other combinations of search filters simply can't be done. Glitchy caching - Mentioned here Vault - Cache?

Here's what the new vault features:

  • Easier search filters - The old search filters (a combination of clicking and typing) have been rewritten as a form where you can select exactly what you want to filter by, and it'll work.
  • Search past page 1 of results - Yup, you can now browse all the pages of your search results.
  • More accurate cache invalidation - Things should no longer linger in the cache after you change them.

Finally, a few other tiny things:

  • Quick vault quantity doesn't jump like 10, 25, 50 anymore, it just has all the numbers from 1 to 50. Hopefully that's better?
  • Categories are listed alphabetically. (More on this below.)
  • Sorting options can each be ascending or descending now. (Previously, only userprice had both ascending/descending options - the rest were ascending only.)

VAULT CATEGORIES Also part of the rewrite I added a categories page. On this page, you can create, delete, and rename vault categories. The page has instructions on how to do these things. Please note: Custom ordering is not currently possible, but vault categories will show up alphabetically in the new vault, so you could put a number in front of each name (for instance) to force an ordering for now. (We ARE planning to add custom ordering in the future.)

Feedback

Okay so, here is the link to the beta vault. Feel free to use it like you'd normally use your vault - that is, use it instead of the vault on site for a couple days and see how it works for you.

What I'm primarily looking for feedback on:

  • Does it work? If anything is broken, please let me know asap - including the caching. (And I guess it's worth repeating the reminder that exploiting a glitch can get you in trouble, so if you find a way to dupe items or something, just report it and don't abuse it.)
  • Is it really slow compared to the old vault? If you get any complete timeouts that don't go away after a page refresh or two, please let me know.

BEFORE REPORTING A BUG

  • Make sure you're actually on my dev site (bug.dev.subeta rather than subeta)
  • Clear your custom CSS to make sure it's not a conflict with the custom code
  • Check your zoom (for instance, many people view Subeta zoomed in or out - the dev site will NOT have the same settings by default)
  • Check your browser extensions and settings (something might be blocking the Javascript)
  • Make sure the bug happens to you more than once; if you can't reproduce it, it could've been a one-time fluke or due to random lag/unrelated factors.

WHEN REPORTING A BUG I need this information:

  • Browser and browser version
  • Operating system + version
  • What device are you on (laptop, mobile, tablet, etc) If you can give instructions on how I can trigger the bug for myself, that would be super helpful :D Otherwise I'll ask you questions to try and get more info.

Okay go check it out and let me know how it goes :D

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 27, 2017 8 years ago Official
Bug
User Avatar
Segfault

Well we're not really interested in removing features (like mass moving items in and out) and in any case the limit of 50 is something we've found to be reasonable - it's not too large but still lets you move a lot at once. If the numbers column is too narrow, would it help if we increased the font-size / padding of that dropdown menu? What if we changed it to an input box where you could just type a number, instead of having to select a number from a dropdown?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 27, 2017 8 years ago Official
Bug
User Avatar
Segfault

Your image isn't clear to me. Can you please describe what you're doing and what the error is?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 27, 2017 8 years ago Official
Bug
User Avatar
Segfault

Thanks for clarifying, I'll look into it and be back with an update asap.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 28, 2017 8 years ago Official
Bug
User Avatar
Segfault

What do you mean by saying you cannot see them? It sounds like you can see them, since they show up if you filter by 'none' or 'all' categories. They wouldn't show up if you have the filter set to anything else, because they would be in the 'none' category if you just moved them into your vault. EDIT: I think I know what you mean, is that they don't show up after you move them back into the vault, unless you do a search first? Cuz I think that's part of the caching that was overlooked since it doesn't happen on the vault page itself (but rather from use item/quickstock). I'll look at fixing that up!

As for the intuitiveness of the dropdown, other than labeling it with the word "Category" I'm not sure what could be done. We don't want to set it to 'all' by default because:

  1. The current vault also views 'no category' items by default
  2. Viewing all of the items would put a lot more strain on the server, since it's literally asking for every single item in your vault, on the homepage.

The reason it's set to 'none' is because that's what the homepage shows. I could show things in no category, but set the dropdown to 'all' by default - but that could be confusing since it doesn't match what the page is showing.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Made a bunch of fixes based on things you guys reported, thank you!!

Editing category names This was broken on Firefox due to how it detects the "enter" key, and has now been fixed to work as it should.

Caching when moving things into the vault Moving items into the vault from the Use Item page and from the Quick stock page should show up immediately now because the cache takes it into account now.

Redirecting after moving items mentioned this, "The one thing I would say that could be improved, is that when I have changed the sort order to "stack size" go to page 6, then removed three sets of items and put in my pin.... the vault still displays page 6, but the sort order has defaulted back to name, which kind of makes it pointless still showing the page number I was on before, as the sort order then changes!" It should now redirect with the correct search parameters, not just the page number.

Selecting items by clicking the item picture mentioned this, "The only thing I miss is the option to click on the piccy to select an item instead of the tick box only because sometimes my old eyes don't work well, however that is something that I can (and maybe others) can get used to. 😊" So now clicking the item name and image both work to select the check box.

I think what you said is pretty unfair to Amber, because typing a pet name versus typing a number are two different things. It doesn't take much thought or effort to type "15" to remove 15 items, or to type "6000 sP" to price an item in your shop. But if I had to type the name "angry pointy thing" every time I wanted to read a book to my mortiking, it would be way too much typing for me! That's because pet names can be long and complex, whereas numbers are usually not that long or complicated. So that's why it's not reasonable to type pet names on the Use Item page, but it might be reasonable to type the number on the vault page. Does that make sense?

Anyway, I experimented with the dropdown to try and make it easier for you. In the end what I did was increase the width of this column so that it's easier to stay within the dropdown when you are making the selection. Could you let me know if this helps at all? I will keep thinking about what other things I can do to make this accessible in the meantime.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

That's odd because the cache should be clearing immediately when you recategorize an item. Are you sure you're doing this all on my dev site? (The dev site has a cache completely separate from the real Subeta, so when the cache gets updated there, it doesn't get updated necessarily on the real site.)

[edit] Editing to add that I did attempt to reproduce your error. However when I moved an item into a new category, and refreshed the main page, the change showed up immediately. It didn't require any extra refreshing. If you've double-checked that you're on the dev, could you please provide some more specific detail/steps I could take to try and run into the same problem?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Is it something that only happened to you those few times, or is it still getting stuck if you try to do it right now? And lol... well hopefully this new vault will be replacing it soon so you won't have to deal with that!

I changed the dropdown to say "(Unsorted)" instead of "(None)" so that it's clearer it only means items that are not in a category. Hopefully that makes it less confusing?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Don't worry about the floating items - that's just a quirk of my dev site :) I should probably make a note about that in the OP.

Quote
When removing an item from the dev vault, the page that loads is entirely blank, but items are indeed removed from the dev vault.
Is this when you remove items using the X link, the All link, or using the form at the bottom of the page?

As for your other point, others have also brought that up... I wrote on the previous page of this topic about the different thoughts I had about it. But I've just changed it so All Categories instead of No Categories is the default selection in the search dropdown. (sorry for all the pings!!! but this was an issue you mentioned too, so I'd love if you could also take a look at this and see if you like it better this way)

Let me know what you think of that :) It should at least be more intuitive so if there's less complaints about it being this way then we'll keep it like this.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Sorry for the double-ping! I just realized I skipped over this part of your post. For the size issue, I think maybe you have Subeta on 90% zoom or something and that's why they look smaller there? Cuz in reality they are about the same size - 140px width plus a bit of margin/padding. When I look at both at 100% zoom they're almost identical and show the same number per row.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Yeah haha. Your browser thinks it's a completely different website, because the domain is different (even though they both end in subeta.net) so it doesn't use the same zoom settings.

I think I've fixed the blank page issue, can you try it again for me please? It just redirects you to the vault main page now. :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Haha. The normal vault keeps the page number in the redirect, but it doesn't keep the category, sorting order, or anything else. It's a bit too complicated right now to make it keep all of the other stuff, so I figure just making it redirect to the main page is fine for now. (Keeping the page number isn't useful if you were also in a category, or sorting by userprice or something, and it doesn't keep that info too.)

I think this was never an issue mostly because, for most of those things, it wouldn't even let you go to page 2 in the first place :P

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Did you use my dev site to place items back into the vault? If you used your quickstock or inventory page on the real subeta, then it would not have updated the cache correctly. So your item would not have shown up right away since the cache wouldn't have updated to show it yet.

(I know... all this dev site stuff is confusing...)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

Yes, it's just the caching that's preventing you from seeing it.

This won't be an issue once the vault is moved onto the real website. It happens because only the dev pages are coded to update the vault's cache. But they will all be merged in eventually.

If you want to try it on the dev site, go to your quickstock page, and change the beginning "https://subeta.net" to "http://bug.dev.subeta.net" to get the dev site URL. (Yes, the dev site is HTTP and not HTTPS, so it's not secure. Don't buy CSC on my dev site basically XD)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 29, 2017 8 years ago Official
Bug
User Avatar
Segfault

@ Raggy How did you try putting it back into your vault? (Like did you use quick stock, or did you do it from the inventory page?)

EDIT JK I think I fixed it now!! Thank you!!

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 2, 2017 8 years ago Official
Bug
User Avatar
Segfault

Under the Search Filters form, do you see a dropdown menu that says "Category" on it? That dropdown menu should have all your categories in it. Under the dropdown, there's a link to go to the page that allows you to edit, add, and delete categories.

If you still don't see it, please remove your custom CSS and check again in case the CSS is accidentally hiding it. If it's still not there, please screenshot for me what you see under Search Filters and I will investigate further.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 2, 2017 8 years ago Official
Bug
User Avatar
Segfault

I think it tripped you up mostly because it's so different from what you've been used to. I don't think changing it is necessary, at least not at this point. I guess if I change the title from "Search Filters" to "Filter Items" it might be more clear what the form is for? But over time I hope it will be less of a problem as people get used to it. Using a dropdown for the categories here is more consistent with how it's done elsewhere on the site, such as wardrobe drawers and shop/gallery categories.

Those are things we can think about implementing in the future, but aren't included in our current update.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Dec 3, 2017 8 years ago Official
Bug
User Avatar
Segfault

Hey everyone, my dev site is open once again if you want to keep using the new vault for stuff :) Sorry it was closed for so long yesterday.

http://bug.dev.subeta.net/explore/vaults.php?vault=item

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Please log in to reply to this topic.