Replies

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Hey everyone! I've circled back 'round to battle stuff and this time I bring you a new-and-improved Statistics page! You can check it out here!

The goal of this revamp was to solve a lot of problems with the old statistics page, both inside and out. Inside, the old page was a lot less efficient. The new page should take less time to load because of improved logic. On the outside, the new page has the information in a more compact and easy-to-view form, so you can quickly get an overview of what your statistics look like for a given pet and opponent. The data is presented in tables now and even color-coded to help you a bit visually :)

We did have to take images out of the tables, but this was a sacrifice we chose to make because the images were part of what made the old page so bloated and hard to process.

A few key notes, that I know people will ask about:

-- The "Forfeit Battle" link will now show up on the main "Challenge an Opponent" page if you are in the middle of the battle. It'll be at the top of the page; you can't miss it! -- For pet name and inactive account stalkers, the same URL still works to take you to the page with a dropdown so you can still see a user's pets that way. -- The totals on each pet/opponent page should update instantly, but the grand totals (for the entire account) are cached.

I hope you enjoy this change, and know that there are more changes to come; In particular, huge improvements to the armory and scroll library are coming up next!

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by DrJeff
Is there any chance of showing the opponents that we haven&;t battled yet so we know which ones we have left to battle?

I talked with on this and the tentative answer is no. This is because it would not be feasible to do this with event and throwback opponents, since they change all the time and some come back on a regular basis. So like, if an event started, you would still have battle history with the opponent from the previous event, even though it's in the clear for the new event. The only way to tell the difference would be to code specific times for events and all... It's just so much trouble it doesn't seem worth it. Sorry.

Quote by Quest

I live this! However, I like to see the artwork of challengers.
Could it be too much to ask a link to artwork by clicking their name on battle records?

You can see these from the main page, by selecting the name from the Opponents dropdown. The image should automatically change to the selected opponent.

Quote by Marlboro
I have 4 Careaper on my battle pet stats page, is it correct?

Is PsychoDreamer your battle pet? I only see Careaper listed twice if so, which is correct. The first is normal Careaper, the second is the Friday the 13th form. They have the same name. I think we have a couple opponents that are like that, unfortunately there's not much to be done about it if they are just named the same thing.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Thank you for reporting that little CSS bug! I've just made a fix.

With the new server, changes take a bit of time to update on the actual site (like 15 minutes ish) so if it's still doing it for you, please wait 15 minutes in case it's just not updated yet c:

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

@ Rocketlauncher Yes, a fix was already made and pushed. But things don't update instantly, because the server has to do fancy stuff rebuilding itself when I make changes. It is closer to 15-20 minutes now for changes to show up.

[edit] I don't know about the phrasing change, is it really ambiguous to say Stats there?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by smilesnz
Could there be another box with a dropdown list of challengers we have not battled yet, then we can see that. Or is that similar to what you and Jason discussed and not able to do?

That's exactly what we discussed and aren't able to do, sorry.

Yeah, I just noticed too. It is extremely odd, because it's showing up correctly on my dev, but on the main site it's broken for some reason even though the code has now updated. I'm going to keep looking at it to see what's going on.

What pet are you looking at that has Careaper listed 4 times?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Okay! I think I finally got it fixed! (The issue with the alignment I mean.) It turns out there was a subtle difference on the two servers. I kinda got confused myself... because my first fix appeared to work on my dev site, but then it didn't work on production. Halfway through, I thought I found the problem, so I pushed another fix. That didn't seem to change anything, but then suddenly it worked after like 20 minutes (so my second change did fix it after all) ahhhhh sorry for all the confusion there.

I figured out the Careaper thing too by the way! It should only be showing twice, one for normal Careaper and one for Friday the 13th Careaper. However it was showing up multiple times for multiple years. I've written and pushed a fix for that and this time it will hopefully work just fine in 15 minutes or so ^^

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Hm that's strange then, because now the issue is fixed for me and I double-checked like 5 times that I wasn't on my dev xD

Can you try Ctrl+F5 to hard refresh the page, and also clear your browser cache? If those two things don't work, remind me your browser, browser version, and what size you have the window on and I'll investigate it further when I'm back tomorrow. I'm clocking out for the night as I'm a bit tired from everything today :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

and others posting about layout/alignment problems - Please include your browser information along with your screenshot, otherwise it's not helpful to me D: thank you!

Quote by Masquerade
I know you addressed this in another post, but what about if it&;s only for standard and normal unlockable challengers instead of event ones? Would that remove the issue because it no longer lists the ones that are reset for every event (eg Jellies, Halloweens etc).

First, when I discussed this with , he brought up that most users would want this feature for event/throwback opponents and use it for that more than the unlockable ones, especially people with only one battle pet since then opponents are sort of just once-and-done.

Second, I just want to clarify what you guys are asking here. If we had this feature for normal opponents, would you want this list to show up on the main page, or have this list generated per pet (that is, when viewing a specific pet's stats, it shows you which opponents that pet has not yet battled). We are definitely not putting it on the main page. The other option, we can consider, but how necessary is it? When would you need such a feature (that is, searching for the challenger name on that page isn't good enough)? I'm sure you can think of a scenario where you do need it, but we have to take into account how often it happens, and how many people will ever encounter it.

I see a lot of you seem disappointed here so I just want to give some insight in how I think about it. A lot of my decision-making on what to implement is based on the idea of a cost-to-benefit ratio. Sometimes I call it effort-to-benefit. Things that we need to be done, I generally don't care how much effort it will take, but things that we don't need but would be nice to have I judge based on this ratio. The issue with this feature is that the cost is somewhat high. We'd have to figure out the actual details of the new feature, how to incorporate it into the design, the implementation itself... none of which are quick or simple. So even though we can see the benefit of such a feature, we're not yet convinced.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

What screen resolution are you guys on? Can you also double-check that you are viewing the page at 100% zoom? It will definitely mess it up if you are zoomed in for instance. I was unfortunately not able to reproduce this on Chrome or Firefox, so more investigation is necessary...

Quote by BoaConstrictor
What makes me a bit sad is that the pets are in alphabethical and not custom order (in challenger view). That makes it hard to distinguish and check my pet blocks. Would it be feasible to choose what we prefer?
Quote by Its_Just_Me
Also is it possible to have the pets listed in the Battle Records for Opponent in the same order as the Battle Records for Pet? It seems like it would be a bit more cohesive.

Yes, I can make it order based on your custom pet order instead. But it would have to be one or the other, not both that and alphabetical. But I think custom pet order makes more sense and is more consistent with the rest of the website, so I will change this.

Quote by Its_Just_Me
One little change I would LOVE to see though is to have the opponents annotated by type - Like (N) for normal, (CS) for Cash Shop, (S) for Secret, and (E) for Event.
Quote by Archer
If I had to nitpick (which I don&;t. but I&;m gonna), I&;d love it if were possible to further sort the lists by difficulty or challenger type, i.e. Cash Shop, Secret, Normal.

Unfortunately this isn't feasible right now, sorry.

Quote by Metroid
It&;d be a subtle quick change and maybe not doable, but maybe for opponents that have 10 or more wins, make that a dark green colour so the brighter green for non-10 win opponents stand out even further?
We are not doing this because the 10-wins thing is going to change in the future. Possibly near future... who knows... ;)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Re: showing opponents you haven't battled yet

Thanks for the discussion and suggestions! Unfortunately I have bad news which is, after considering your points, and thinking really hard about how such a thing would even be coded, I've found it's not feasible to implement right now. So this is an official "no" from me, sorry.

I will include some reasoning behind this, but at this point it's not up for debate. In the future I'd be willing to talk about it again but I'll let you know when that is. Right now, consider it "shelved" because, after thinking about it, it would take more time and effort than I'm willing to give right now. Basically I realized "This would still be nice to have, but not nice enough to be worth delaying the armory and scrollery updates as much as it would."

Some reasoning behind this Without getting too technical, it's partly because we can't easily distinguish between the different types of challengers (event, throwback, currently available...) and the feature loses a lot of its usefulness if we can't have that. (Eventually you would have like 50 old throwback challengers listed for some of your pets, and it would still be hard to find the info you're looking for, which is opponents you haven't fought that you can fight now.)

The information for the type of challengers we'd need to look up in a separate database table than your battle logs. The thing is, these pages are already doing a lot of database reads and computation because of the battle logs themselves, and I really hesitate to add more computation to this page when it's a feature the majority are fine without - and I mean we have lived without this for a long time and been okay.

It would also be quite tricky to work it into the existing code. It would require a full rewrite of the logic that generates the tables. This is less of an issue than the above, but it matters because there's a high chance that it would take a while and break a lot in the meantime if I tried to do it. Hence, it would be possibly multiple days spent on this instead of the armory and scrollery updates I wanted to do. By the time I was done, it might be time for me to circle back to other projects so you guys would have to wait even longer for those.

Okay, so all of that aside, I can however show pets that have not battled an opponent, when you are viewing the history of a specific opponent. That wouldn't be all that hard, funnily enough. Would that be something you guys would like?

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

No, sorry, they're going to remain alphabetical.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 4, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by Bug
Okay, so all of that aside, I can however show pets that have not battled an opponent, when you are viewing the history of a specific opponent. That wouldn&;t be all that hard, funnily enough. Would that be something you guys would like?

I've decided to do this, it seems like a good compromise. Please be patient as I work on adding it :)

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 5, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by Its_Just_Me
would it be feasible to just put the annotation after the opponent name above the image? I didn&;t mean for them to be sortable, just something to know what category to find them in or if they are even available (in the case of event opponents).

No, sorry.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Oct 6, 2017 8 years ago Official
Bug
User Avatar
Segfault

and anyone else with the alignment/page width problem: I think I finally fixed the problem with the CSS. Could you please check? I've had my computer set to lower resolutions and I really think I got it fixed this time xD

Everyone else, a tiny update: Pets are now shown in your custom order :)

More to come~

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Nov 10, 2017 8 years ago Official
Bug
User Avatar
Segfault

Quote by BoaConstrictor
Unrelated to statistics.

You can post your bug reports in the problems+bugs forums! As for everything else, please be patient for now. Revamps are in the works for those pages, I just haven't gotten to them yet.

🐝 ☕ bug (he/him) | your friendly neighborhood code wrangler. stay in the loop! join and check out the latest admin post highlights

Please log in to reply to this topic.